Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Guides] Bump lodash for a security vulnerability #3273

Merged
merged 1 commit into from Jul 19, 2019

Conversation

kennyadsl
Copy link
Member

Description

CVE-2019-10744

This is not critical since we only use lodash in development

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
    - [ ] I have updated Guides and README accordingly to this change (if needed)
    - [ ] I have added tests to cover this change (if needed)

CVE-2019-10744
lodash/lodash#4336

This is not critical since we only use lodash in development
@kennyadsl kennyadsl self-assigned this Jul 17, 2019
@kennyadsl kennyadsl changed the title Bump lodash for a security vulnerability [Guides] Bump lodash for a security vulnerability Jul 17, 2019
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @kennyadsl

Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒 Nice work!

@kennyadsl kennyadsl merged commit a378e74 into solidusio:master Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants