[v4.3] Show "Unavailable" status for products with a future Available On date
#5743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
3 tasks
tvdeyen
changed the title
Available On date
tvdeyen
approved these changes
May 3, 2024
Currently if a product has the `available_on` date in the future, it will still show a status of Available, even though it is not available for purchase on the store. This change proposes a new status of `Unavailable` for scheduled products. Co-authored-by: Harmony Bouvier <harmony@super.gd> (cherry picked from commit e404e44)
This change fixes an issue where certain browsers (namely Firefox) will not render the date field correctly when it contains the full date and time format as the value. This change just truncates the available_on and discontinue_on values to match the precision expected, rather switch to the datetime-local input which is not fully supported in all browsers, but also maintains the old admin behaviour. Co-authored-by: Andrew Stewart <andrew@super.gd> (cherry picked from commit 1fdb686)
tvdeyen
force-pushed
the
backport/v4.3/pr-5734
branch
from
3f07371
to
ba3b251
Compare
|
rebased with v4.3 to fix issues with sqlite3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintov4.3:Questions ?
Please refer to the Backport tool documentation