Use Null Promotion Configuration in core #5744
Open
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
mamhoff
force-pushed
the
use-null-promo-config
branch
from
09b93ba
to
82c98ae
Compare
github-actions
bot
added
the
changelog:repository
mamhoff
force-pushed
the
use-null-promo-config
branch
from
82c98ae
to
636e27b
Compare
github-actions
bot
added
the
changelog:solidus_api
mamhoff
force-pushed
the
use-null-promo-config
branch
from
636e27b
to
a0c8ca0
Compare
jarednorman
reviewed
May 28, 2024
mamhoff
force-pushed
the
use-null-promo-config
branch
3 times, most recently
from
bb52430
to
c7c2761
Compare
github-actions
bot
removed
changelog:solidus_api
With the NullPromotionConfiguration, the default promotion attributes are an empty list. In order to test whether attributes can be deleted from this list, we first have to add an attribute.
We want to use the legacy `Spree::PromotionConfiguration` in the solidus_legacy_promotions test suite.
mamhoff
force-pushed
the
use-null-promo-config
branch
from
c7c2761
to
77a2aab
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5744 +/- ##
===========================================
+ Coverage 75.56% 88.71% +13.15%
===========================================
Files 711 711
Lines 17796 16886 -910
===========================================
+ Hits 13447 14980 +1533
+ Misses 4349 1906 -2443 ☔ View full report in Codecov by Sentry. |
tvdeyen
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to use the legacy
Spree::LegacyPromotions::Configurationonly in the solidus_legacy_promotions test suite. In the core test suite, we use theSpree::Core::NullPromotionConfiguration. This will finally allow us to move all the classes and specs to thesolidus_legacy_promotionsgem in a future PR.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: