chore: update k8s dependencies #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
puertomontt
commented
May 7, 2024
| @@ -59,9 +55,6 @@ type DynamicSource struct { | |||
|
|
|||
| // has source started? | |||
| started *startArgs | |||
|
|
|||
| // the channel to which to push events | |||
| output source.Channel | |||
There was a problem hiding this comment.
appears unused, and source.Channel is no longer a type
saiskee
reviewed
May 13, 2024
| @@ -251,7 +251,7 @@ var _ = Describe("ManifestsRenderer", func() { | |||
| Expect(err).NotTo(HaveOccurred()) | |||
| Expect(outFiles).To(HaveLen(2)) // legacy and templated manifests | |||
| Expect(outFiles[0].Content).To(ContainSubstring(crdutils.CRDVersionKey + ": 1.0.0")) | |||
| Expect(outFiles[0].Content).To(ContainSubstring(crdutils.CRDSpecHashKey + ": b6ec737002f7d02e")) | |||
There was a problem hiding this comment.
non blocking -- make this a constant?
jenshu
approved these changes
May 13, 2024
saiskee
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update k8s deps to v0.30.0
handle breaking changes from kubernetes-sigs/controller-runtime#2783
Context
Summary of issue
Description and justification of any interesting decisions made
BOT NOTES:
resolves https://github.com/solo-io/gloo-mesh-enterprise/issues/14822