Bump "symfony/phpunit-bridge" constraint to "^5.1" #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another way to fix it is using ^5.1.1 on require dev |
VincentLanglet
requested changes
Jun 14, 2020
There was a problem hiding this comment.
I prefer the @jordisala1991 solution.
Adding conflict for require-dev doesn't seems to be a good idea to me.
If I want to install this bundle and phpunit-bridge@5.1.0 on a project, I should be able to do it because I won't run the sonata test.
A conflict-dev section could be used. But it doesn't exist...
phansys
force-pushed
the
phpunit_bridge
branch
2 times, most recently
from
4696c2e
to
de2b16c
Compare
|
Based on your concern, I've removed the global conflict. |
VincentLanglet
previously approved these changes
Jun 14, 2020
phansys
changed the title
jordisala1991
approved these changes
Jun 14, 2020
|
Thank you @phansys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Bump "symfony/phpunit-bridge" constraint to "^5.1", in order to avoid conflicts with
TestCase::expectDeprecation().See symfony/symfony#37153.
I am targeting this branch, because this change respects BC.
Triggered by #302 (comment).
Changelog