Fix deprecation messages in AdminResettingController and AdminResettingController

[phansys]

Subject

Fix deprecation messages in AdminResettingController and AdminResettingController, since currently they are making references to non existing classes.

I am targeting this branch, because these changes respect BC.

[jordisala1991]

There might me something wrong on tests:

Since symfony/phpunit-bridge 5.1: Using "@expectedDeprecation" annotations in tests is deprecated, use the "ExpectDeprecationTrait::expectDeprecation()" method instead.

seems like we using the old way of expecting deprecations. Deprecated 😅

[phansys]

There might me something wrong on tests:

I've replaced those annotations. The test should be fine now.

[jordisala1991]

I think this is only needed if you using really old versions of phpunit. on 8.5 we should be fine without it

[phansys]

I can confirm it is required. We are using phpunit/phpunit:8.5.0:

SonataUserBundle/phpunit.xml.dist

Line 35 in d60215e

<env name="SYMFONY_PHPUNIT_VERSION" value="8.5.0" />

Please, see symfony/symfony#37153.

[jordisala1991]

Oh I see, needed then, I was confused with the expectException

[VincentLanglet]

There should be no changelog, for pedantic isn't it ?

And I think two commit would be better.

• One with the deprecation message fix
• One removing the deprecated @expectedDeprecation. (Not sure if it was really needed btw, since we'll remove all of them in the next major ; all the other SonataBundle use this annotation, so now we're in a not-consistent situation 😅)

[phansys]

Changelog section removed, since these changes are pedantic. It was:

Changelog

### Fixed
- Fixed QCNs referenced by deprecation messages at `AdminResettingController` and `AdminResettingController`;
- Fixed deprecated usage of `@exptectedDeprecation` through `ExpectDeprecationTrait::expectDeprecation()`.

[phansys]

There should be no changelog, for pedantic isn't it ?

Changelog removed.

And I think two commit would be better.

Commits splitted.

[jordisala1991]

Thank you @phansys