#147 Drop usage of shadow plugin #151
Merged
+8
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaikhu
changed the title
|
Since we rely heavily on log output, perhaps we want to go ahead with this change alongside with #146 so all big changes start with a new major release together? |
That sounds sensible to me 👍 |
shaikhu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugin is no longer deployed as an uber jar. This PR drops all usage/configuration of the shadown plugin.
Unintended consequence
It appears by dropping shadowing we are no longer using slf4j logger at runtime, but default gradle logging implementation. This means unless
--infois supplied to the gradle command, the logging information will not be displayed.It relates to the following issue #s:
cc @bhamail / @DarthHater / @guillermo-varela / @shaikhu