Allow onChange when onBlur is present (microsoft#813)

soon · Apr 2, 2019 · 517de21 · 517de21
1 parent e92a08f
commit 517de21
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/reactA11yNoOnchangeRule.ts b/src/reactA11yNoOnchangeRule.ts
@@ -59,7 +59,7 @@ function walk(ctx: Lint.WalkContext<Options>) {
         }
 
         const attributes = getJsxAttributesFromJsxElement(node);
-        if (attributes.hasOwnProperty('onchange')) {
+        if (attributes.hasOwnProperty('onchange') && !attributes.hasOwnProperty('onblur')) {
             const errorMessage = `onChange event handler should not be used with the <${tagName}>. Please use onBlur instead.`;
             ctx.addFailureAt(node.getStart(), node.getWidth(), errorMessage);
         }

diff --git a/src/tests/ReactA11yNoOnchangeRuleTests.ts b/src/tests/ReactA11yNoOnchangeRuleTests.ts
@@ -35,6 +35,15 @@ describe('reactA11yNoOnchangeRule', (): void => {
         ]);
     });
 
+    it('should not fail if select element attributes contains onBlur event even if it also contains onChange event', (): void => {
+        const script: string = `
+            import React = require('react');
+            const selectElementWithOnChange = <select  onChange={} onBlur={} />\`;
+        `;
+
+        TestHelper.assertNoViolation(ruleName, script);
+    });
+
     it('should fail if additional tag name specified in options contains onChange event', () => {
         const script: string = `
             import React = require('react');