Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor]: some refactors in Remove Liquidity #238

Merged
merged 3 commits into from
Dec 12, 2022
Merged

[refactor]: some refactors in Remove Liquidity #238

merged 3 commits into from
Dec 12, 2022

Commits on Dec 8, 2022

  1. [chore]: comment out unused code

    @0x009922
    0x009922 committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    8f2825a View commit details
    Browse the repository at this point in the history

  2. [refactor]: refactor rm-store a bit 

    - use `PairAddressResult` as a source of
  truth in more places (less duplication)
- rename the store's `isPairLoaded` to
  `doesPairExist` for better semantics
- clear selected addrs at `.clear()`
- when "supply" is closed, navigate to
  liquidity only when the supply was
  fulfilled
- on refresh, update the pair address too
    @0x009922
    0x009922 committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    24527f7 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2022

  1. [fix][klaytn#174]: avoid underlying watchEffect in rm-store

    @0x009922
    0x009922 committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    d4c91bd View commit details
    Browse the repository at this point in the history