Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kdump] Capture more commands for RH kdump #3612

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcastill
Copy link
Member

This change enables the RH plugin to display the content of /var/crash via the command 'ls', and adds a new option to capture the latest vmcores generated
in the last 24 hours, smaller than 2GB, as it's
done in the AzureDump class.


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3612
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@jcastill jcastill requested a review from pmoravec May 20, 2024 12:02
@jcastill jcastill marked this pull request as ready for review May 20, 2024 12:04
sos/report/plugins/kdump.py Outdated Show resolved Hide resolved
sos/report/plugins/kdump.py Outdated Show resolved Hide resolved
This change enables the RH plugin to display the content
of /var/crash via the command 'ls', and adds a new
option to capture the latest vmcores generated
in the last 24 hours, smaller than 2GB, as it's
done in the AzureDump class.

Signed-off-by: Jose Castillo <jcastillo@redhat.com>
@jcastill
Copy link
Member Author

I've changed the option in the Azure plugin as well, because it was strange to have two different formats for the option. We haven't shipped the Azure kdump changes made some weeks ago yet, right? So no user has seen the option and we have still the room to change it.
That said, I was thinking on moving the option from get-vm-core to get-vmcore. It reads more naturally (we never asked for a vm-core in support, it was always vmcore) and the file itself is not hyphenated. What do you think?

I'm still working on merging Azure and RH plugins because they are almost the same, but that will have to be another PR.

Copy link
Member

@arif-ali arif-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Azure bit was already changed by Jake

nevertheless, I think the Azure Linux folks have their own way of incorporating stuff, at least based on hat I saw a few months back, when they were trying to get 4.6.1 in. So, it could be that, when they added it here, they may of updated their RPMs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants