Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microovn] Added new plugin support for MicroOVN #3632

Merged
merged 1 commit into from May 10, 2024

Conversation

alanbach
Copy link
Contributor


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3632
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

1 similar comment
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3632
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Copy link
Member

@jcastill jcastill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small things because I'm not that familiar with snap. @arif-ali will pick up anything I missed, but from the little I understand it looks good.

sos/report/plugins/microovn.py Outdated Show resolved Hide resolved
sos/report/plugins/microovn.py Outdated Show resolved Hide resolved
sos/report/plugins/microovn.py Outdated Show resolved Hide resolved
sos/report/plugins/microovn.py Outdated Show resolved Hide resolved
sos/report/plugins/microovn.py Outdated Show resolved Hide resolved
sos/report/plugins/microovn.py Outdated Show resolved Hide resolved
sos/report/plugins/microovn.py Outdated Show resolved Hide resolved
sos/report/plugins/microovn.py Outdated Show resolved Hide resolved
sos/report/plugins/microovn.py Outdated Show resolved Hide resolved
@alanbach alanbach changed the title **[microovn]** Added new plugin support for MicroOVN. [microovn] Added new plugin support for MicroOVN. Apr 30, 2024
@alanbach alanbach changed the title [microovn] Added new plugin support for MicroOVN. [microovn] Added new plugin support for MicroOVN Apr 30, 2024
sos/report/plugins/microovn.py Outdated Show resolved Hide resolved
sos/report/plugins/ovn_central.py Fixed Show resolved Hide resolved
Signed-off-by: Alan Baghumian <alan.baghumian@canonical.com>
Copy link
Member

@arif-ali arif-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me

@TurboTurtle TurboTurtle merged commit 3ff7286 into sosreport:main May 10, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants