Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make interpreter's Conjunction a Compound node #2459

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

quentin
Copy link
Member

@quentin quentin commented Dec 19, 2023

Conjunctions with hundreds of terms would otherwise overflow the engine stack with left/right recursion.
The issue has been observed in Debug build with ~200 terms.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #2459 (bba07d6) into master (f766700) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2459      +/-   ##
==========================================
- Coverage   78.20%   78.15%   -0.05%     
==========================================
  Files         486      486              
  Lines       32379    32394      +15     
==========================================
- Hits        25322    25318       -4     
- Misses       7057     7076      +19     
Files Coverage Δ
src/interpreter/Engine.cpp 85.21% <100.00%> (+0.04%) ⬆️
src/interpreter/Generator.cpp 95.20% <100.00%> (+0.09%) ⬆️
src/interpreter/Node.h 96.96% <ø> (ø)

... and 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant