Fix some clang tidy warnings #2464
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly adding noexcept to some move assignments/ctors so they are utilized by STL. Also adding some std::move calls to avoid certain potentially expensive copies. Some misc fixes/improvements including fixing typos in comments.
quentin
previously approved these changes
Dec 23, 2023
Xazax-hun
force-pushed
the
tidy-fixes
branch
from
0bb1e72
to
8016caa
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2464 +/- ##
==========================================
+ Coverage 78.18% 78.21% +0.02%
==========================================
Files 486 486
Lines 32422 32420 -2
==========================================
+ Hits 25349 25357 +8
+ Misses 7073 7063 -10
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly adding noexcept to some move assignments/ctors so they are utilized by STL. Also adding some std::move calls to avoid certain potentially expensive copies. Some misc fixes/improvements including fixing typos in comments.