Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tables part 1 #2837

Draft
wants to merge 22 commits into
base: master
Choose a base branch
from
Draft

Refactor tables part 1 #2837

wants to merge 22 commits into from

Conversation

RichDom2185
Copy link
Member

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

* Create `DataTable` component abstraction
* Replace `AgGridReact` with `DataTable`
The idea is to try to minimise the need for CSS workarounds as much as
possible. Should they be required nonetheless, they will be restored in
a subsequent commit.
@RichDom2185 RichDom2185 self-assigned this Mar 10, 2024
@coveralls
Copy link

coveralls commented Mar 10, 2024

Pull Request Test Coverage Report for Build 8957886922

Details

  • 0 of 8 (0.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 32.728%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pages/academy/adminPanel/subcomponents/AddStoriesUserPanel.tsx 0 1 0.0%
src/pages/academy/adminPanel/subcomponents/AddUserPanel.tsx 0 1 0.0%
src/pages/academy/adminPanel/subcomponents/NotificationConfigPanel.tsx 0 1 0.0%
src/pages/academy/adminPanel/subcomponents/assessmentConfigPanel/AssessmentConfigPanel.tsx 0 1 0.0%
src/pages/academy/adminPanel/subcomponents/userConfigPanel/UserConfigPanel.tsx 0 1 0.0%
src/pages/academy/groundControl/GroundControl.tsx 0 1 0.0%
src/commons/dataTable/DataTable.tsx 0 2 0.0%
Totals Coverage Status
Change from base Build 8937138713: -0.003%
Covered Lines: 5146
Relevant Lines: 14693

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants