Shared links frontend #2890

Rachelcoll · 2024-03-30T04:49:33Z

Description

change of shared links routes (/plaground/share/:uuid)'
change shared links generation procedure (check ControllBarShareButton.tsx and Encoder.tsx)
change procedure of accepting and identify shared links (check Playground.tsx and Decoder.tsx)

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
Code quality improvements

How to test

Checklist

I have tested this code (all functionality works on my local computer fine, not sure why it cannot pass pre-push hooks check)
I have updated the documentation

Update on 4.12
Things still need to improve:

Cannot find Wrapper function for fetch request
How to fetch frontend url since there's no Constant frontend url
Still fail to pass 4 Playground test

Personal thoughts to oop:

Personally I suggest remove OOP design of Encoder since currently we only need new way to generate url, no need to generate queryString

RichDom2185

Please rerun yarn format and also fix all the remaining issues.

package.json

tsconfig.json

RichDom2185 · 2024-03-31T03:46:33Z

src/routes/routerConfig.tsx

+      {
+        path: 'playground/share/:uuid?',
+        lazy: Playground
+      },


I thought the new share link generation will be for Source Academy @ NUS only? Why is it instead only in the public deployment route (and not for SA @ NUS)? @chownces can you confirm? I may not have the latest information from the meetings.

Agree. Let's shift this to a 'with-backend' only router.

src/pages/playground/Encoder.tsx

src/pages/playground/Decoder.tsx

src/pages/playground/Playground.tsx

…demy/frontend into shared-links-frontend

RichDom2185 · 2024-04-01T02:33:48Z

Please run your lint checks locally and format the files before pushing.

RichDom2185

Please run your lint checks locally and format the files before pushing.

I've reverted all the changes to the lockfile and TypeScript language config, as well as fixed the format errors but there are still warnings and unfixable errors. Please fix all of them, thanks!

…demy/frontend into shared-links-frontend

RichDom2185

Hi, thanks for working on this. However, after doing a quick run-through, as it stands, this can't be merged due to numerous bugs and just code quality issues overall.

Could you improve them? Thanks a lot!

package.json

src/commons/controlBar/ControlBarShareButton.tsx

src/pages/playground/Encoder.tsx

…k state

RichDom2185

Thanks a lot for working on refactoring the code! Can I check is this PR ready? If it's not, please mark it as draft again, thanks!

yarn.lock

src/features/playground/shareLinks/ShareLinkState.tsx

src/features/playground/shareLinks/encoder/URLEncoder.tsx

src/pages/playground/Playground.tsx

martin-henz · 2024-04-13T08:47:50Z

This PR has a failing test suite now:

FAIL src/pages/playground/__tests__/Playground.tsx
  ● Test suite failed to run

src/commons/controlBar/ControlBarShareButton.tsx

src/pages/playground/Playground.tsx

…demy/frontend into shared-links-frontend

Rachelcoll · 2024-04-13T12:38:32Z

Basically there's not much UI added in this PR, so I just put a demo video of whole process here.

51b071877c9363ff2759c02e7b3f82bc_raw.mp4

Error page when fail to grab program from share link (due to invalid url or web disconnected:

Error page when fail to create share link:

…nto shared-links-frontend

src/features/playground/shareLinks/ShareLinkState.ts

src/commons/controlBar/ControlBarShareButton.tsx

src/features/playground/shareLinks/encoder/Encoder.tsx

src/pages/playground/Playground.tsx

chownces · 2024-04-14T18:48:21Z

src/routes/routerConfig.tsx

+      {
+        path: 'playground/share/:uuid?',
+        lazy: Playground
+      },


Agree. Let's shift this to a 'with-backend' only router.

chownces · 2024-04-14T18:50:14Z

See #2937

* Refactor ControlBarShareButton to functional react * Update hotkeys implementation * Re-add playground configuration encoder * Migrate external URL shortener request out of sagas * Implement retrieval of playground configuration from backend UUID and reinstate configuration by hash parameters * Update test suite * Mock BrowserFS in nodejs test environment * Fix mock file error * Update hotkeys binding * Update usage of uuid decoder * Update tests

…nto shared-links-frontend

coveralls · 2024-04-15T11:40:13Z

Pull Request Test Coverage Report for Build 9107001964

Details

79 of 127 (62.2%) changed or added relevant lines in 12 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.2%) to 31.601%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/features/playground/shareLinks/decoder/delegates/JsonDecoderDelegate.ts	0	1	0.0%
src/features/playground/shareLinks/encoder/delegates/JsonEncoderDelegate.ts	0	1	0.0%
src/features/playground/shareLinks/encoder/delegates/UrlParamsEncoderDelegate.ts	0	1	0.0%
src/features/playground/shareLinks/encoder/Encoder.ts	1	3	33.33%
src/pages/playground/Playground.tsx	22	25	88.0%
src/features/playground/shareLinks/encoder/EncoderHooks.ts	2	21	9.52%
src/commons/controlBar/ControlBarShareButton.tsx	18	39	46.15%

Files with Coverage Reduction	New Missed Lines	%
src/features/playground/PlaygroundReducer.ts	1	60.0%
src/pages/playground/Playground.tsx	1	56.17%

Totals
Change from base Build 9101202777:	0.2%
Covered Lines:	4924
Relevant Lines:	14697

💛 - Coveralls

…nto shared-links-frontend

Rachelcoll added 3 commits March 28, 2024 12:56

connect shared links creation with backend database

635cde8

shared links procedure change

c4c0747

shared links url change

5b655e0

Rachelcoll requested a review from chownces March 30, 2024 04:56

Merge branch 'master' into shared-links-frontend

2b99c40

RichDom2185 requested changes Mar 31, 2024

View reviewed changes

Rachelcoll added 2 commits March 31, 2024 17:15

delete unnecessary lines

91b84e1

Merge branch 'shared-links-frontend' of https://github.com/source-aca…

5218f9d

…demy/frontend into shared-links-frontend

RichDom2185 added 4 commits April 1, 2024 17:39

Merge branch 'master' into shared-links-frontend

a67a6b7

Fix format errors

b6f036b

Revert lockfile change

2315ede

Revert TS config change

d133925

RichDom2185 requested changes Apr 1, 2024

View reviewed changes

Rachelcoll and others added 7 commits April 3, 2024 22:42

test check

0f0fb61

Merge branch 'shared-links-frontend' of https://github.com/source-aca…

76c2178

…demy/frontend into shared-links-frontend

format

0a356ca

format

55c81a8

format

557d23a

Merge branch 'master' into shared-links-frontend

ccb8023

Fix incorrect merge resolution

91a0a1e

RichDom2185 requested changes Apr 6, 2024

View reviewed changes

chownces and others added 4 commits April 7, 2024 23:39

Add OOP-oriented implementation of encoding and decoding of share lin…

8518e65

…k state

debug and add decoder oop

433c81e

debug and add decoder oop

bfe97cc

Merge branch 'master' into shared-links-frontend

b1842b4

RichDom2185 requested changes Apr 13, 2024

View reviewed changes

Rachelcoll and others added 2 commits April 13, 2024 16:15

remove decoder oop and fix bugs

6e7dcc4

Merge branch 'master' into shared-links-frontend

7bd35c8

RichDom2185 requested changes Apr 13, 2024

View reviewed changes

src/commons/controlBar/ControlBarShareButton.tsx Outdated Show resolved Hide resolved

src/pages/playground/Playground.tsx Outdated Show resolved Hide resolved

src/pages/playground/Playground.tsx Outdated Show resolved Hide resolved

martin-henz and others added 3 commits April 13, 2024 18:10

Merge branch 'master' into shared-links-frontend

cf4c625

change request method and fix bugs

cc412f0

Merge branch 'shared-links-frontend' of https://github.com/source-aca…

49537fc

…demy/frontend into shared-links-frontend

RichDom2185 added 4 commits April 13, 2024 20:38

Revert lockfile changes

5618a03

Merge branch 'master' of https://github.com/source-academy/frontend i…

fe9eea2

…nto shared-links-frontend

Merge branch 'master' into shared-links-frontend

d7333da

Merge branch 'master' into shared-links-frontend

840e5d5

chownces requested changes Apr 14, 2024

View reviewed changes

Rachelcoll marked this pull request as draft April 15, 2024 06:46

chownces and others added 2 commits April 15, 2024 17:02

Merge branch 'master' of https://github.com/source-academy/frontend i…

9b701f0

…nto shared-links-frontend

RichDom2185 and others added 5 commits May 5, 2024 19:04

Merge branch 'master' of https://github.com/source-academy/frontend i…

b48948a

…nto shared-links-frontend

Merge branch 'master' of https://github.com/source-academy/frontend i…

ecb2063

…nto shared-links-frontend

Merge branch 'master' of https://github.com/source-academy/frontend i…

bde45d1

…nto shared-links-frontend

Merge branch 'master' into shared-links-updated

2cf4672

Remove redundant playground saga test

59e8106

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shared links frontend #2890

Shared links frontend #2890

Rachelcoll commented Mar 30, 2024 •

edited

RichDom2185 left a comment

RichDom2185 Mar 31, 2024

chownces Apr 14, 2024

RichDom2185 commented Apr 1, 2024

RichDom2185 left a comment

RichDom2185 left a comment

RichDom2185 left a comment

martin-henz commented Apr 13, 2024

Rachelcoll commented Apr 13, 2024

chownces Apr 14, 2024

chownces commented Apr 14, 2024

coveralls commented Apr 15, 2024 •

edited

Shared links frontend #2890

Are you sure you want to change the base?

Shared links frontend #2890

Conversation

Rachelcoll commented Mar 30, 2024 • edited

Description

Type of change

How to test

Checklist

RichDom2185 left a comment

Choose a reason for hiding this comment

RichDom2185 Mar 31, 2024

Choose a reason for hiding this comment

chownces Apr 14, 2024

Choose a reason for hiding this comment

RichDom2185 commented Apr 1, 2024

RichDom2185 left a comment

Choose a reason for hiding this comment

RichDom2185 left a comment

Choose a reason for hiding this comment

RichDom2185 left a comment

Choose a reason for hiding this comment

martin-henz commented Apr 13, 2024

Rachelcoll commented Apr 13, 2024

chownces Apr 14, 2024

Choose a reason for hiding this comment

chownces commented Apr 14, 2024

coveralls commented Apr 15, 2024 • edited

Pull Request Test Coverage Report for Build 9107001964

Details

💛 - Coveralls

Rachelcoll commented Mar 30, 2024 •

edited

coveralls commented Apr 15, 2024 •

edited