Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement participant indicator for sessions #2948

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

izruff
Copy link
Contributor

@izruff izruff commented Apr 19, 2024

Description

Adds cursor display for other users in the same session and fixed related bugs.
This PR is associated with source-academy/sharedb-ace-backend#26 and source-academy/sharedb-ace#26

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Multiple users join the same session. Upon entering, cursors of other users should automatically show. Each cursor whenever updated will move to its new position and show a label containing the name of the user associated with it ("undefined" if no name is detected).

To test the sharedb-ace package locally, run yarn build then yarn link on the sharedb-ace repository, then run yarn link @sourceacademy/sharedb-ace on the frontend repository.

Checklist

  • I have tested this code
  • I have updated the documentation

@RichDom2185 RichDom2185 self-requested a review April 19, 2024 10:27
@coveralls
Copy link

coveralls commented Apr 19, 2024

Pull Request Test Coverage Report for Build 9101316786

Details

  • 3 of 6 (50.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.007%) to 31.417%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/editor/UseShareAce.tsx 3 6 50.0%
Files with Coverage Reduction New Missed Lines %
src/commons/editor/UseShareAce.tsx 1 22.64%
Totals Coverage Status
Change from base Build 9101202777: 0.007%
Covered Lines: 4894
Relevant Lines: 14676

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants