-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement participant indicator for sessions #2948
Open
izruff
wants to merge
21
commits into
master
Choose a base branch
from
feat/participant-indicator
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichDom2185
force-pushed
the
feat/participant-indicator
branch
from
April 19, 2024 10:34
49b34ca
to
b737786
Compare
Pull Request Test Coverage Report for Build 9101316786Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds cursor display for other users in the same session and fixed related bugs.
This PR is associated with source-academy/sharedb-ace-backend#26 and source-academy/sharedb-ace#26
Type of change
How to test
Multiple users join the same session. Upon entering, cursors of other users should automatically show. Each cursor whenever updated will move to its new position and show a label containing the name of the user associated with it ("undefined" if no name is detected).
To test the
sharedb-ace
package locally, runyarn build
thenyarn link
on thesharedb-ace
repository, then runyarn link @sourceacademy/sharedb-ace
on the frontend repository.Checklist