This repository has been archived by the owner on Sep 8, 2020. It is now read-only.
chore: upgrade got package #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsoch
approved these changes
Jan 15, 2020
There was a problem hiding this comment.
Wow that's quite a few breaking changes! It looks like you changed the got.get request to exactly as it should be for the new release, asking for "buffer" instead of null and changing encoding to responseType. If tests pass with this change, we should be good, and I assume that if there were other uses of the module (I'm not familiar with the code base) tests wouldn't pass given the change. So LGTM.
Full list of breaking changes listed here. https://github.com/sindresorhus/got/releases/tag/v10.0.0 One breaking change affected our usage: "Use the responseType option instead of encoding to get a Buffer" sindresorhus/got#940 - got(…, {encoding: null}); + got(…, {responseType: 'buffer'});
Beanow
force-pushed
the
pr/upgrade-got
branch
from
c42bdaa
to
426cbb3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full list of breaking changes listed here.
https://github.com/sindresorhus/got/releases/tag/v10.0.0
One breaking change affected our usage:
"Use the responseType option instead of encoding to get a Buffer"
sindresorhus/got#940
Closes: #45
Test plan:
yarn testpasses