space key no longer triggers commit of selected mention item #4154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqs
force-pushed
the
sqs/at-mention-spacebar
branch
from
9b6cb4e
to
3cf3f4d
Compare
thenamankumar
approved these changes
May 13, 2024
This behavior existed to preserve parity with the pre-Lexical-editor behavior, but I think we should remove it because it will interfere with more complex @-mentions where the "query" does need to include spaces. (For example, think about @-mentioning a title of a doc with spaces in it.)
sqs
force-pushed
the
sqs/at-mention-spacebar
branch
from
c6523a0
to
2ec850e
Compare
|
Confirmed Tab still works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior existed to preserve parity with the pre-Lexical-editor behavior, but I think we should remove it because it will interfere with more complex @-mentions where the "query" does need to include spaces. (For example, think about @-mentioning a title of a doc with spaces in it.)
Test plan
CI