Add overlay tests #4020
Draft
Add overlay tests #4020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,44 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Each overlay has its own test file that implements setup, deploy, verify and cleanup. This code is very similar between overlays and can be simplified.
| @@ -0,0 +1,29 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
| @@ -0,0 +1,27 @@ | |||
| apiVersion: policy/v1beta1 | |||
There was a problem hiding this comment.
| @@ -0,0 +1,9 @@ | |||
| kind: StorageClass | |||
There was a problem hiding this comment.
| @@ -0,0 +1,26 @@ | |||
| { | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a new test suite based off the existing restricted tests and expands it to include other overlays. The suite creates a new GKE cluster (latest version) and reuses it for each overlay. My goal here was to stay close to the original test implementation and see where the sticking points were before changing too dramatically.
Not all overlays are tested. This is not yet hooked into CI because it's still a proof-of-concept and needs additional work. I've been successfully using it to verify local changes and it's even revealed a potential problem with the storage overlay.
Checklist