Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demonstration: sg ops update produces nasty formatting diffs / doesn't work as expected #4207

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

slimsag
Copy link
Member

@slimsag slimsag commented Dec 6, 2022

DO NOT MERGE

This is a demonstration that sg ops update doesn't really work today.

This change was produced via:

sg ops update-images -t 187572_2022-12-06_cbecc5321c7d -kind k8s ./base

Most changes here are innocuous, but a few formatting changes here are quite aggressive:

Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
@slimsag
Copy link
Member Author

slimsag commented Dec 6, 2022

This appears to produce the least intrusive diff (still formatting in some files, but not too bad):

sg ops update-images -t 187572_2022-12-06_cbecc5321c7d -kind k8s ./base
git checkout -- **/*.ConfigMap.yaml **/*.Role.yaml **/*.Ingress.yaml **/*.Service.yaml **/*.IndexerService.yaml
git add base/

@slimsag slimsag changed the title demonstration: sg ops update not working demonstration: sg ops update produces nasty formatting diffs / doesn't work as expected Dec 6, 2022
slimsag added a commit that referenced this pull request Dec 6, 2022
Produced via:

```
sg ops update-images -t 187572_2022-12-06_cbecc5321c7d -kind k8s ./base
git checkout -- **/*.ConfigMap.yaml **/*.Role.yaml **/*.Ingress.yaml **/*.Service.yaml **/*.IndexerService.yaml
git add base/
```

See also #4207

Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
@slimsag
Copy link
Member Author

slimsag commented Dec 6, 2022

Another complaint/observation:

sg ops update-images cannot update the pure-docker/ directory in https://github.com/sourcegraph/deploy-sourcegraph-docker which means the changes it wants to make to that repository are always incomplete (it would be bad to merge a change there to only Docker Compose and not the bash scripts.)

slimsag added a commit that referenced this pull request Dec 6, 2022
* all: replace minio with sourcegraph/blobstore
* all: update image tags

Produced via:

```
sg ops update-images -t 187572_2022-12-06_cbecc5321c7d -kind k8s ./base
git checkout -- **/*.ConfigMap.yaml **/*.Role.yaml **/*.Ingress.yaml **/*.Service.yaml **/*.IndexerService.yaml
git add base/
```

See also #4207

Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
slimsag added a commit that referenced this pull request Dec 7, 2022
* all: replace minio with sourcegraph/blobstore
* all: update image tags

Produced via:

```
sg ops update-images -t 187572_2022-12-06_cbecc5321c7d -kind k8s ./base
git checkout -- **/*.ConfigMap.yaml **/*.Role.yaml **/*.Ingress.yaml **/*.Service.yaml **/*.IndexerService.yaml
git add base/
```

See also #4207

Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
slimsag added a commit that referenced this pull request Dec 7, 2022
* all: replace minio with sourcegraph/blobstore (#4206)

* all: replace minio with sourcegraph/blobstore
* all: update image tags

Produced via:

```
sg ops update-images -t 187572_2022-12-06_cbecc5321c7d -kind k8s ./base
git checkout -- **/*.ConfigMap.yaml **/*.Role.yaml **/*.Ingress.yaml **/*.Service.yaml **/*.IndexerService.yaml
git add base/
```

See also #4207

Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>

* all: update image tags to :4.2_187939_2022-12-07_5d744edd0103

Produced via:

```
sg ops update-images -t 4.2_187939_2022-12-07_5d744edd0103 -kind k8s ./base
git checkout -- **/*.ConfigMap.yaml **/*.Role.yaml **/*.Ingress.yaml **/*.Service.yaml **/*.IndexerService.yaml
git add base/
```

Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>

Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant