Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish the enterprise enhanced context panel #1479

Merged
merged 6 commits into from May 16, 2024

Conversation

dominiccooney
Copy link
Contributor

Changes to the enterprise enhanced context panel:

  • Pluralizes repo/repos in the repo tree view summary line
  • Updates counts in the repo tree view summary line
  • Mentions the number of ignored repos in the repo tree view summary line (if any)
  • Adds a help tooltip with a link to documentation
  • Removes the help button from the right-hand side toolbar
  • Clicking outside the repo picker popup accepts the edits instead of cancelling them
  • Alt-tabbing while the repo picker popup is open does not dismiss it

Part of #1322

Test plan

Tested manually.

  1. Run with CODY_JETBRAINS_FEATURES=cody.feature.internals-menu=true
  2. Sign into an Enterprise account
  3. Verify the repo picker is collapsed, one line and the edit pencil is visible
  4. Hover the repo picker and verify the tooltip, opening the link goes to context documentation

Screenshot 2024-05-10 at 20 23 52

  1. Add repos and verify the summary line language updates, pluralization is correct, etc.
  2. Use Internals, Testing: Cody Ignore and ignore some repositories, check the "ignored" language updates, etc.

Screenshot 2024-05-10 at 20 25 19

  1. Verify the details of adding repositories with the pencil:

    • Change text, press ESC, repo list should not update
    • Change text, press cmd-enter, repo list should update
    • Change text, click outside popup, repo list should update (new behavior)
  2. Open the pencil popup, verify that cmd-tab/alt-tab away from IntelliJ and back does not close the popup

Copy link
Contributor

@pkukielka pkukielka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mkondratek mkondratek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried it on macOs. Things work ok according to your Test Plan.


I noticed this.

  1. Hover on "Chat Context X Repos"
  2. "About chat context" tooltip appears
  3. Hover on a repository
  4. Both "About chat context" and repository url (or info about included repo)
image

Is it ok that we present these two tooltips at once?

messages-panel.welcome-text=Hello! I'm Cody. I can write code and answer questions for you. See [Cody documentation](https://sourcegraph.com/docs/cody) for help and tips.
EndOfTrialNotification.link-action-name=Setup Payment Info
EndOfTrialNotification.do-not-show-again=Don't show again
TrialEndingSoonNotification.ignore=cody.ignore.notification.trial-ending-soon
TrialEndingSoonNotification.ending-soon.title=Your Cody Pro trial is ending soon
TrialEndingSoonNotification.ending-soon.content=Setup your payment information to continue using Cody Pro, you won't be charged until February 21.
TrialEndingSoonNotification.ending-soon.content=Set up your payment information to continue using Cody Pro, you won't be charged until February 21.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not for this PR but we may be able to get rid of TrialEndingSoonNotification

Copy link
Contributor

@mkondratek mkondratek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it on windows too - works 🚀

@dominiccooney
Copy link
Contributor Author

Is it ok that we present these two tooltips at once?

@mkondratek yeah that's not ideal... @danielmarquespt wanted the tooltip to just trigger for the top row, actually. But that will take some work because the tree view items' tooltips are only text.

Another problem with this is the positioning gets in the way of the treeview expand/collapse disclosure arrow.

@toolmantim is working on a refresh of this UI, so this may not live long.

If it is still an issue after the refresh I'll work on custom triggering. It is cheesy but maybe we can watch the mouse movement and push the tooltip in and out of the tooltip properties when the mouse is in the "hot zone" on the top row. Needs investigation whether that will hide the tooltip once it is visible.

@dominiccooney dominiccooney merged commit baed387 into main May 16, 2024
5 of 6 checks passed
@dominiccooney dominiccooney deleted the dpc/repo-picker-polish branch May 16, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants