[Backport 5.3.14141] release: disable promotion of development releas…

…e & add --development flag to baseFlags (#62459)

release: disable promotion of development release & add --development flag to baseFlags (#62336)

(cherry picked from commit 90b797b)

Co-authored-by: Bolaji Olajide <25608335+BolajiOlajide@users.noreply.github.com>

dev/sg/internal/release/config.go

@@ -355,6 +355,11 @@ func (r *releaseRunner) Test(ctx context.Context) error {
 }
 
 func (r *releaseRunner) Promote(ctx context.Context) error {
+	if r.isDevelopment {
+		announce2("promote", "Skipping promote, this is a development release")
+		return nil
+	}
+
 	if err := r.checkRequirements(ctx, stagePromoteCreate); err != nil {
 		return err
 	}
@@ -363,6 +368,11 @@ func (r *releaseRunner) Promote(ctx context.Context) error {
 }
 
 func (r *releaseRunner) PromoteFinalize(ctx context.Context) error {
+	if r.isDevelopment {
+		announce2("promote", "Skipping promote finalize, this is a development release")
+		return nil
+	}
+
 	if err := r.checkRequirements(ctx, stagePromoteFinalize); err != nil {
 		return err
 	}

dev/sg/internal/release/release.go

@@ -49,6 +49,11 @@ var releaseBaseFlags = []cli.Flag{
 		Value: false,
 		Usage: "Infer run configuration from last commit instead of flags.",
 	},
+	&cli.BoolFlag{
+		Name:    "development",
+		Aliases: []string{"d"},
+		Usage:   "Create a development release. This is a release that is not meant to be promoted to public, but is meant to be used by other developers to test their changes. It is not meant to be used by customers.",
+	},
 }
 
 // releaseRunFlags are the flags for the release run * subcommands. Version is optional here, because
@@ -69,11 +74,6 @@ var releaseCreatePromoteFlags = append(releaseBaseFlags, []cli.Flag{
 		Usage:    "Force version (required)",
 		Required: true,
 	},
-	&cli.BoolFlag{
-		Name:    "development",
-		Aliases: []string{"d"},
-		Usage:   "Create a development release. This is a release that is not meant to be promoted to public, but is meant to be used by other developers to test their changes. It is not meant to be used by customers.",
-	},
 }...)
 
 var Command = &cli.Command{