New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: reactstrap tooltips causing browser tab to freeze #4922
Conversation
The issue is filed in reactstrap here: reactstrap/reactstrap#1482 |
Alternatively, we can use a workaround that was mentioned in the issue. Pushed that commit up here: b65c7de |
Codecov Report
@@ Coverage Diff @@
## master #4922 +/- ##
==========================================
+ Coverage 48.09% 48.09% +<.01%
==========================================
Files 732 732
Lines 44645 44641 -4
Branches 1763 1763
==========================================
- Hits 21471 21470 -1
+ Misses 21207 21204 -3
Partials 1967 1967
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felixfbecker there's quite a number of places we use tooltips that could potentially be affected: https://sourcegraph.com/search?q=r:%5Egithub.com/sourcegraph/sourcegraph%24+data-tooltip There's actually a slightly better workaround in that issue. I think that's the workaround we should implement, actually. 7f2671e |
3f3b4e5
to
7f2671e
Compare
@felixfbecker the flip modifier tries to flip the direction of the popover if it's too close to the edge of the container. It's on by default, and seems to be what causes the tooltip to freak out as it tries to flip in an infinite loop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@attfarhan can you update the PR description to describe the final diff.
@keegancsmith fyi as release captain this will need to get cherry-picked into the release branch
Disables the `flip` modifier on the tooltip component, a temporary workaround for the bug in reactstrap.
flip: { | ||
enabled: false, | ||
}, | ||
}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When adding a workaround like this, add a comment linking to the issue so we know to remove it when the issue is fixed
Fixes #4853.
The commit d9e6207 resulted in a bug that would cause the entire page to freeze if the tooltip popovers that appear when hovering on some buttons had too much content, which is a bug in the upgraded version of reactstrap. This PR implements a workaround mentioned in the issue, which disables the
flip
modifier of the tooltip.