Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Svelte]: Improve result indicator layout #62338

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vovakulikov
Copy link
Contributor

The main intention to change here is to save vertical space, we already have a few panels and sticky headers in the search result block, and having an additional row in the sticky header above make this panel crowded especially on mid-size screens

Before After
Screenshot 2024-05-01 at 14 16 47 Screenshot 2024-05-01 at 14 15 52

Test plan

  • Check progress result UI on the search result page

@vovakulikov vovakulikov requested review from taiyab and a team May 1, 2024 12:20
@vovakulikov vovakulikov self-assigned this May 1, 2024
@cla-bot cla-bot bot added the cla-signed label May 1, 2024
@camdencheek
Copy link
Member

Looks like this will conflict with #62317. Thoughts on how we should handle that?

@vovakulikov
Copy link
Contributor Author

So after the pairing session, we agreed that this PR won't go to the May release, instead, we're going to merge #62317 and in this PR we split the result button into two buttons, info one with result count and reasons badge and action button which populates the query with additional filter to resolve the problem that info button shows

@vovakulikov vovakulikov marked this pull request as draft May 1, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants