Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svelte: Enable repo routes by default #62374

Merged
merged 1 commit into from May 7, 2024

Conversation

fkling
Copy link
Contributor

@fkling fkling commented May 2, 2024

(in preparation for the S2 rollout)

This commit enables the following routes via the web-next-rollout flag:

  • repo home
  • blob
  • file
  • branches
  • tags
  • commits
  • commit

Question: Should we also enable the contributors page by default? It would be the only page left but it didn't receive any attention.

Test plan

Inspected generated code.

@fkling fkling added do-not-merge team/code-search Issues owned by the code search team labels May 2, 2024
@fkling fkling requested a review from camdencheek May 2, 2024 07:27
@fkling fkling self-assigned this May 2, 2024
@cla-bot cla-bot bot added the cla-signed label May 2, 2024
@fkling fkling force-pushed the fkling/sk/enable-repo-pages-by-default branch from 548cba9 to 312841e Compare May 6, 2024 09:05
@fkling fkling requested a review from a team May 6, 2024 09:06
Copy link
Contributor

@vovakulikov vovakulikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Contributors page can wait. It doesn't block any core workflows

This commit enables the following routes via the `web-next-rollout`
flag:

- repo home
- blob
- file
- branches
- tags
- commits
- commit
@fkling fkling force-pushed the fkling/sk/enable-repo-pages-by-default branch from 312841e to 3b7e884 Compare May 7, 2024 11:00
@fkling fkling enabled auto-merge (squash) May 7, 2024 11:00
@fkling fkling merged commit c8cb66a into main May 7, 2024
12 checks passed
@fkling fkling deleted the fkling/sk/enable-repo-pages-by-default branch May 7, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed team/code-search Issues owned by the code search team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants