Check if access requests are enabled before redirecting to auth provider #62376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team/product-platform
team/source
eseliger
approved these changes
May 2, 2024
mmanela
reviewed
May 2, 2024
| // If there is only one auth provider that is going to be displayed, we want to redirect to it directly. | ||
| if (thirdPartyAuthProviders.length === 1 && !builtInAuthProvider) { | ||
| // If there is only one auth provider that is going to be displayed, and request access is disabled, we want to redirect to the auth provider directly. | ||
| if (thirdPartyAuthProviders.length === 1 && !builtInAuthProvider && !isRequestAccessAllowed) { |
There was a problem hiding this comment.
What is isRequestAccessAllowed ? What is the request access feature?
There was a problem hiding this comment.
Whether or not a user can request access to the sourcegraph instance https://docs.sourcegraph.com/admin/config/site_config#auth-accessRequest
There was a problem hiding this comment.
Added some docs here: sourcegraph/docs#289
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #62313
This PR adds an additional check to the automatic redirect check that checks if request access is enabled or not, and only redirects if request access is disabled, otherwise there would be no way to request access to the instance.
Test plan
Added tests for redirect behaviour and verified locally