WIP - Feature/ci install from sources on centos7 #patch #230
Conversation
MarkGibbons
changed the title
MarkGibbons
changed the title
MarkGibbons
added
the
Release: Patch
| node.default['yum']['centos-sclo']['enabled'] = true | ||
| node.default['yum']['centos-sclo']['managed'] = true | ||
| node.default['yum']['centos-sclo-rh']['enabled'] = true | ||
| node.default['yum']['centos-sclo-rh']['managed'] = true | ||
| include_recipe 'yum-centos' | ||
|
|
||
| yum_package 'devtoolset-7-gcc-c++' |
There was a problem hiding this comment.
This really should be included in the source recipe for the cookbook so that it works "out of the box" for users. We can use an attribute to turn this on/off for air gap environments.
There was a problem hiding this comment.
I agree that the package should be installed in mainline code. But, I don't think this cookbook is the right place to set up a a yum repository. We could set up repository access for centos, but that's a case where we have network access to the centos repository. Building from source is probably a thing to do when network access is not available so setting up the repository seems pointless.
We also are not setting up access to repositories for other platforms. RHEL setup is outside of this cookbook. For Debian we are are running apt-get commands outside the cookbook to make it work. Centos7 is, for me, an edge case that doesn't need special handling in the main recipe.
There was a problem hiding this comment.
We setup repositories in other cookbooks if we need them to get it working. I don't see why that can't be the case here, especially if we make it optional for air gapped environments. I think for most use cases, users would expect this to work out of the box without having to add more code to get it to work on EL7.
Install yum repo centos-sclo-rh on centos7 in a test fixture Enable dokken centos7 source suite Install devtoolset-7-gcc-c++ for the centos 7 source build Update source_centos7.rb Move the package install and setup for centos7 and rhel7 to the cookbook recipes Remove code specific to opensuse 42 Remove the install of python from ubuntu 20.04 in dokken.yml The python install for ubuntu 20.04 is now in the recipe.
MarkGibbons
force-pushed
the
feature/ci-install-from-sources-on-centos7
branch
from
3aa3a76
to
b2392ac
Compare
Description
Add and update #227
Move the needed package install from a test recipe to the cookbook source install recipe
Issues Resolved
[List any existing issues this PR resolves]
Check List