Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compensate for NPM CLI deprecating -global #246

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Compensate for NPM CLI deprecating -global #246

wants to merge 4 commits into from
+9 −7

Conversation

Brantone
Copy link
Contributor

@Brantone Brantone commented Jun 7, 2022 •
edited

Move to recommended --location=global param

Description

NPM CLI is deprecating -global ... recently release prints it to stderr (though another release reverts it).

Issues Resolved

#245

Check List

  • A summary of changes made is included in the CHANGELOG under ## Unreleased
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

@Brantone Brantone requested a review from a team as a code owner June 7, 2022 01:32
@Brantone
Copy link
Contributor Author

Brantone commented Jun 7, 2022

Bunch of errors spitting out of Dokken that at first brush not sure how they're related.

@Brantone Brantone mentioned this pull request Jun 8, 2022
Open
@Brantone
Copy link
Contributor Author

Brantone commented Jun 9, 2022

Note :
Some older versions of NPM don't yet support --location ... it's not yet known when that was introduced.
Mitigation would be to do a check using npm -v and react according.

@ramereth ramereth added the Release: Minor Release to Chef Supermarket as a minor release when merged label Aug 7, 2022
@ramereth ramereth linked an issue Aug 8, 2022 that may be closed by this pull request
NPM CLI is deprecating -global #245
Open
@ramereth
Copy link
Contributor

ramereth commented Aug 8, 2022

Note : Some older versions of NPM don't yet support --location ... it's not yet known when that was introduced. Mitigation would be to do a check using npm -v and react according.

This seems to be correct based on the failures here. This needs to be addressed before merging/releasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Release: Minor Release to Chef Supermarket as a minor release when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPM CLI is deprecating -global
2 participants
@Brantone @ramereth