Make client settings match server settings and improve docs (#189) #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kind Prediction: docs Provide the bot with feedback using a 👍 or 👎! |
|
Size Prediction: medium Nice! This should be quick to review Provide the bot with feedback using a 👍 or 👎! |
I did not write new tests because the |
|
Whoops, I broke it 😭 fixing now! |
As described in issue sous-chefs#198, make settings in the client configs (E.G. `auth`, `cipher`, `compress`, etc) match their server counterparts. This eliminates warnings in the OpenVPN log about inconsistent option usage. In addition, document how the `openvpn_user` resource works, including showing how additional configuration options can be added to client conf files (using `additional_vars` and `cookbook_user_conf`) Squashed commit of the following: commit 91542b9 Author: Josh Gitlin <jgitlin@pinnacle21.com> Date: Fri May 14 15:04:28 2021 -0400 Add changelog entry commit 858f41c Author: Josh Gitlin <jgitlin@pinnacle21.com> Date: Fri May 14 15:00:21 2021 -0400 Bugfix node name commit dab2949 Author: Josh Gitlin <jgitlin@pinnacle21.com> Date: Fri May 14 14:33:29 2021 -0400 Cookstyle fixes commit d587ae1 Author: Josh Gitlin <jgitlin@pinnacle21.com> Date: Fri May 14 14:31:33 2021 -0400 MDL fixes commit eda83e5 Author: Josh Gitlin <jgitlin@pinnacle21.com> Date: Fri May 14 12:05:37 2021 -0400 Added documentation for vpn_user resource commit 61172d8 Author: Josh Gitlin <jgitlin@pinnacle21.com> Date: Thu May 13 21:48:09 2021 -0400 Make client settings match server settings commit c14d15a Author: Josh Gitlin <jgitlin@pinnacle21.com> Date: Tue May 11 21:36:18 2021 -0400 Add compression to client configs Signed-off-by: Josh Gitlin <jgitlin@pinnacle21.com>
xorima
approved these changes
Sep 28, 2023
xorima
approved these changes
Sep 28, 2023
xorima
approved these changes
Sep 28, 2023
xorima
previously approved these changes
Sep 29, 2023
Stromweld
added
Feature Request
|
If this PR is still relevant please update to fix the failing test or please close this PR if not needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in issue #198, make settings in the client configs (E.G.
auth,cipher,compress, etc) match their server counterparts. This eliminates warnings in the OpenVPN log about inconsistent option usage.In addition, document how the
openvpn_userresource works, including showing how additional configuration options can be added to client conf files (usingadditional_varsandcookbook_user_conf)Signed-off-by: Josh Gitlin jgitlin@pinnacle21.com
Issues Resolved
#189
Check List