Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue #119] Update fcontext to allow override of built-in types #120

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ywei2017
Copy link

Description

Allow override of of the fcontext of system built-in file specs.

Issues Resolved

Issue #119

Check List

  • [N/A] A summary of changes made is included in the CHANGELOG under ## Unreleased
  • [Will do once the approach is reviewed] New functionality includes testing.
  • [N/A] New functionality has been documented in the README if applicable.

…types

Signed-off-by: Yansheng Wei <wei.yansheng@gmail.com>
@ywei2017
Copy link
Author

See testing, for 3 of the instances, I am having issue with the driver. All others tested fine.

@Stromweld Stromweld added Feature Request Enhancement to existing functionality or new functionality Release: Minor Release to Chef Supermarket as a minor release when merged labels Apr 26, 2024
ywei2017 and others added 2 commits April 29, 2024 10:31
Thanks for suggestion, I will re-run the test.

Co-authored-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
Copy link
Contributor

Can you rebase or merge remote main into your current branch and then fix any failing tests. I just merged new test versions.

@ywei2017
Copy link
Author

ywei2017 commented May 4, 2024 via email

@ywei2017
Copy link
Author

ywei2017 commented May 12, 2024

@Stromweld - Completed the testing. I had issues earlier which turned out to be the version of Chef Workstation I was using. I also had to make wait_for_retry longer as the description said, for some of the test cases.

Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 14 successful, 0 failures, 0 skipped
       Finished verifying <fcontext-almalinux-8> (0m9.87s).
--
Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 14 successful, 0 failures, 0 skipped
       Finished verifying <fcontext-centos-7> (0m9.57s).
--
Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 14 successful, 0 failures, 0 skipped
       Finished verifying <fcontext-centos-stream-8> (0m10.18s).
--
Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 13 successful, 0 failures, 0 skipped
       Finished verifying <fcontext-debian-10> (0m7.61s).
--
Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 13 successful, 0 failures, 0 skipped
       Finished verifying <fcontext-debian-11> (0m7.48s).
--
Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 14 successful, 0 failures, 0 skipped
       Finished verifying <fcontext-fedora-latest> (0m9.35s).
--
Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 14 successful, 0 failures, 0 skipped
       Finished verifying <fcontext-oracle-7> (0m9.40s).
--
Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 14 successful, 0 failures, 0 skipped
       Finished verifying <fcontext-oracle-8> (0m10.29s).
--
Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 14 successful, 0 failures, 0 skipped
       Finished verifying <fcontext-rockylinux-8> (0m9.69s).
--
Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 13 successful, 0 failures, 0 skipped
       Finished verifying <fcontext-ubuntu-1804> (0m7.29s).
--
Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 13 successful, 0 failures, 0 skipped
       Finished verifying <fcontext-ubuntu-2204> (0m8.58s).
--
Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 14 successful, 0 failures, 0 skipped
       Finished verifying <fcontext-amazonlinux-2> (0m9.59s).
--
Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 13 successful, 0 failures, 0 skipped
       Finished verifying <fcontext-ubuntu-2004> (0m8.42s).

@ywei2017
Copy link
Author

@Stromweld - Any further actions on my side for the PR? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Enhancement to existing functionality or new functionality Release: Minor Release to Chef Supermarket as a minor release when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants