-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Fix issues on Windows and add CI testing #448
base: main
Are you sure you want to change the base?
Conversation
Afaik Windows was not a supported platform before, at least it was not in the supports or in the readme. So super interesting that it worked before, but I suppose we will have to exclude some of the tests for Windows as test with a uid will never pass I think. Maybe we can try replacing that with a SID, although I am not sure if you are allowed to chose your own SID. I thought Windows always generated that. |
8a0d162
to
e828fb8
Compare
Signed-off-by: Lance Albertson <lance@osuosl.org>
e828fb8
to
889d441
Compare
In the latest release from PR #467 I updated the CI pipeline and added windows but it failed due to some more linux specific settings in code. Looks to be more work that will need to go into supporting windows then just adding it to CI workflow. |
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
No description provided.