Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - ATX V2 syntactical validation (no deps) #5936

Closed
wants to merge 6 commits into from

Conversation

poszu
Copy link
Contributor

@poszu poszu commented May 14, 2024

Description

Syntactically validate ATX V2 pre-downloading the dependencies.

💡 It only supports non-merged and non-marriage ATXs. It fails when it detects one of these (there are tests for this).

The ATX HandlerV2 is a separate structure so implementing it doesn't interfere with the existing handler implementation for V1.

HandlerV2 is a work-in-progress as it is not yet meant to be embedded into the Handler.

Test Plan

Added unit tests for syntactical validation and decoding an ATX V2`

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 87.80488% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 80.7%. Comparing base (c865710) to head (2ccb522).

Files Patch % Lines
activation/handler_v2.go 90.9% 3 Missing and 3 partials ⚠️
activation/handler.go 42.8% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #5936   +/-   ##
=======================================
  Coverage     80.7%   80.7%           
=======================================
  Files          290     292    +2     
  Lines        30525   30607   +82     
=======================================
+ Hits         24652   24724   +72     
- Misses        4240    4245    +5     
- Partials      1633    1638    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

activation/handler_v2.go Show resolved Hide resolved
activation/handler_v2.go Show resolved Hide resolved
activation/handler_v2.go Show resolved Hide resolved
activation/handler_v2.go Show resolved Hide resolved
@poszu
Copy link
Contributor Author

poszu commented May 23, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request May 23, 2024
@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title ATX V2 syntactical validation (no deps) [Merged by Bors] - ATX V2 syntactical validation (no deps) May 23, 2024
@spacemesh-bors spacemesh-bors bot closed this May 23, 2024
@spacemesh-bors spacemesh-bors bot deleted the atx-handler-v2/syntactical-validation-no-deps branch May 23, 2024 15:28
@poszu poszu restored the atx-handler-v2/syntactical-validation-no-deps branch May 23, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants