-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - ATX V2 syntactical validation (no deps) #5936
Closed
+842
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5936 +/- ##
=======================================
Coverage 80.7% 80.7%
=======================================
Files 290 292 +2
Lines 30525 30607 +82
=======================================
+ Hits 24652 24724 +72
- Misses 4240 4245 +5
- Partials 1633 1638 +5 ☔ View full report in Codecov by Sentry. |
ivan4th
approved these changes
May 15, 2024
…tactical-validation-no-deps
fasmat
reviewed
May 21, 2024
fasmat
approved these changes
May 23, 2024
…tactical-validation-no-deps
bors merge |
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
ATX V2 syntactical validation (no deps)
[Merged by Bors] - ATX V2 syntactical validation (no deps)
May 23, 2024
spacemesh-bors
bot
deleted the
atx-handler-v2/syntactical-validation-no-deps
branch
May 23, 2024 15:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Syntactically validate ATX V2 pre-downloading the dependencies.
💡 It only supports non-merged and non-marriage ATXs. It fails when it detects one of these (there are tests for this).
The ATX
HandlerV2
is a separate structure so implementing it doesn't interfere with the existing handler implementation for V1.HandlerV2
is a work-in-progress as it is not yet meant to be embedded into theHandler
.Test Plan
Added unit tests for syntactical validation and decoding an ATX V2`
TODO