Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Collect and fetch ATX V2 deps #5937

Closed
wants to merge 1 commit into from

Conversation

poszu
Copy link
Contributor

@poszu poszu commented May 14, 2024

Description

Adds:

  • collecting deps of an ATX V2:
    • previous ATXs
    • positioning ATX
    • marriage ATX (using is still forbidden by syntactical validation though)
    • poet proofs
  • registering the IDs of the above objects in the fetcher
  • fetching the deps

Test Plan

Added unit tests

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 80.7%. Comparing base (794aa17) to head (71540cd).
Report is 2 commits behind head on develop.

Files Patch % Lines
activation/handler_v2.go 94.8% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #5937   +/-   ##
=======================================
  Coverage     80.7%   80.7%           
=======================================
  Files          292     292           
  Lines        30607   30646   +39     
=======================================
+ Hits         24721   24757   +36     
- Misses        4248    4250    +2     
- Partials      1638    1639    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poszu poszu force-pushed the atx-handler-v2/fetching-deps branch from e5a59af to 5f0aa80 Compare May 16, 2024 15:17
@spacemesh-bors spacemesh-bors bot changed the base branch from atx-handler-v2/syntactical-validation-no-deps to develop May 23, 2024 15:28
@poszu poszu changed the base branch from develop to atx-handler-v2/syntactical-validation-no-deps May 23, 2024 15:47
@poszu poszu changed the base branch from atx-handler-v2/syntactical-validation-no-deps to develop May 23, 2024 15:48
@poszu poszu force-pushed the atx-handler-v2/fetching-deps branch from 5f0aa80 to 71540cd Compare May 23, 2024 15:59
@poszu
Copy link
Contributor Author

poszu commented May 23, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request May 23, 2024
@spacemesh-bors
Copy link

Build failed:

  • ci-status

@poszu
Copy link
Contributor Author

poszu commented May 23, 2024

Bors merge

spacemesh-bors bot pushed a commit that referenced this pull request May 23, 2024
@spacemesh-bors
Copy link

Build failed (retrying...):

spacemesh-bors bot pushed a commit that referenced this pull request May 23, 2024
@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title Collect and fetch ATX V2 deps [Merged by Bors] - Collect and fetch ATX V2 deps May 23, 2024
@spacemesh-bors spacemesh-bors bot closed this May 23, 2024
@spacemesh-bors spacemesh-bors bot deleted the atx-handler-v2/fetching-deps branch May 23, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants