[Merged by Bors] - Remove duplicated NodeID from ATXV2 #5938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5938 +/- ##
=======================================
Coverage 80.7% 80.7%
=======================================
Files 288 288
Lines 29895 29895
=======================================
+ Hits 24151 24152 +1
+ Misses 4157 4156 -1
Partials 1587 1587 ☔ View full report in Codecov by Sentry. |
fasmat
approved these changes
May 14, 2024
|
Bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
May 14, 2024
## Motivation ATX v2 will have a completely different ID calculation method and it doesn't need the extra NodeID for an initial ATX.
|
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ATX v2 will have a completely different ID calculation method and it doesn't need the extra NodeID for an initial ATX.
Description
Removed
NodeIDfromInitialAtxPartsV2.Test Plan
n/a
TODO