Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Fix numpy nightly wheel install for dev job #1387

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jun 9, 2022

Description

This pull request is to update the incantation to grab "nightly" wheel for numpy for the dev job. It started to fail for unrelated PRs.

xref numpy/numpy#21715 and astropy/astropy#13322

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set?
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Jun 9, 2022
@pllim pllim added this to the 2.7 milestone Jun 9, 2022
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #1387 (e426e29) into main (651f8f4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1387   +/-   ##
=======================================
  Coverage   84.91%   84.91%           
=======================================
  Files          91       91           
  Lines        8288     8288           
=======================================
  Hits         7038     7038           
  Misses       1250     1250           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 651f8f4...e426e29. Read the comment docs.

@pllim
Copy link
Contributor Author

pllim commented Jun 9, 2022

Nope, didn't work. And just realized it has been failing in astropy dev job too. Asked over at numpy/numpy#21706 numpy/numpy#21711 .

Regardless, when server-side is fixed, we should still get this in to be consistent with how astropy calls it.

tox.ini Outdated Show resolved Hide resolved
@pllim
Copy link
Contributor Author

pllim commented Jun 10, 2022

Of course there has to be a real failure... 😒

>       assert flux_viewer.label_mouseover.world_ra_deg == '204.9997755346'
E       AssertionError: assert '' == '204.9997755346'
E         - 204.9997755346
.../jdaviz/configs/cubeviz/plugins/moment_maps/tests/test_moment_maps.py:48: AssertionError

@pllim
Copy link
Contributor Author

pllim commented Jun 10, 2022

I think the failure is related to the same problem astropy.coordinates see in astropy/astropy#13322 . I propose we merge this anyway and monitor the upstream astropy issue.

@pllim pllim marked this pull request as ready for review June 10, 2022 14:16
@pllim
Copy link
Contributor Author

pllim commented Jun 13, 2022

Looks like they fixed the wheels upstream, but we should still get this in.

@pllim pllim merged commit 7c3559e into spacetelescope:main Jun 13, 2022
@pllim pllim deleted the fix-nightly-numpy-ci branch June 13, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive Ready for final review testing trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant