Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coverage job #261

Merged

Conversation

WilliamJamieson
Copy link
Contributor

@WilliamJamieson WilliamJamieson commented Aug 16, 2023

PR tox-dev/tox#3089 released as part of tox 4.9.0 prevents tox from implicitly creating environments. We were using this to create the tox environment for cov. This PR fixes this by explicitly creating the environment in our CI.

Checklist

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5dbd4a2) 96.67% compared to head (b86b8a1) 96.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #261   +/-   ##
=======================================
  Coverage   96.67%   96.68%           
=======================================
  Files          28       29    +1     
  Lines        2406     2413    +7     
=======================================
+ Hits         2326     2333    +7     
  Misses         80       80           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram
Copy link
Collaborator

Thanks for finding this issue and fix so quickly!

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamJamieson WilliamJamieson merged commit 6906708 into spacetelescope:main Aug 20, 2023
17 of 18 checks passed
@WilliamJamieson WilliamJamieson deleted the bugfix/coverage branch August 20, 2023 14:12
WilliamJamieson added a commit to WilliamJamieson/roman_datamodels that referenced this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants