Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genesis: add versions 1.6.1, 1.6.2, 1.7.1, 2.0.0 #33605

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

chig
Copy link

@chig chig commented Oct 30, 2022

Add new versions and patch for fj_compiler on Fugaku.

@spackbot-app
Copy link

spackbot-app bot commented Oct 30, 2022

Hi @chig! I noticed that the following package(s) don't yet have maintainers:

  • genesis

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers = ["chig"]

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame genesis

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@tldahlgren tldahlgren changed the title genesis: add version 2.0 genesis: add versions 1.6.1, 1.6.2, 1.7.1, 2.0.0 Oct 31, 2022
Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed new tag and versions.

var/spack/repos/builtin/packages/genesis/package.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restore the ending copyright year.

@tldahlgren tldahlgren self-assigned this Oct 31, 2022
Co-authored-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com>
@alecbcs
Copy link
Member

alecbcs commented Oct 9, 2023

@chig are you still interested in getting this PR merged into develop? Looks like there's a few merge conflicts that need to be resolved.

@chig
Copy link
Author

chig commented Nov 19, 2023

@alecbcs Thank you for letting me know. I got your message this morning. How I should do it? I uploaded this pull request in 2022. Does this mean I should resubmit the pull request for the current develop version?

@spackbot-app spackbot-app bot added the stand-alone-tests Stand-alone (or smoke) tests for installed packages label Dec 4, 2023
@wdconinc
Copy link
Contributor

@spackbot fix style

Copy link

spackbot-app bot commented May 19, 2024

Let me see if I can fix that for you!

Copy link

spackbot-app bot commented May 19, 2024

I was able to run spack style --fix for you!

spack style --fix
==> Running style checks on spack
  selected: isort, black, flake8, mypy
==> Modified files
  var/spack/repos/builtin/packages/genesis/package.py
==> Running isort checks
  isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/genesis/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
  black checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> Running mypy checks
lib/spack/spack/version/version_types.py:145: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
lib/spack/spack/version/version_types.py:452: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
lib/spack/spack/version/version_types.py:481: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
Found 3 errors in 1 file (checked 625 source files)
  mypy found errors
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point we should reduce the scope of this PR to just include v2 since python@2 required for genesis@1 is not a package in spack anymore.


depends_on("mpi", type=("build", "run"))
depends_on("lapack")

depends_on("python@2.6.9:2.8.0", type=("build", "run"), when="@:1.7.1")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay, but by now no more python@2 dependencies are possible anymore for the current set of package versions in spack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants