Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rayleigh: new package #38338

Merged
merged 6 commits into from
May 21, 2024
Merged

rayleigh: new package #38338

merged 6 commits into from
May 21, 2024

Conversation

tukss
Copy link
Contributor

@tukss tukss commented Jun 12, 2023

This adds a new package for the 3D MHD code Rayleigh.

@tukss tukss force-pushed the rayleigh branch 5 times, most recently from 92b2e96 to 8278bb6 Compare June 13, 2023 05:02
wdconinc
wdconinc reviewed May 18, 2024
View reviewed changes
Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Apologies for the delay to this review. I have given some comments. Please also rebase or merge updates from the develop branch to pick up newer audit and style checks.

var/spack/repos/builtin/packages/rayleigh/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/rayleigh/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/rayleigh/package.py Show resolved Hide resolved
var/spack/repos/builtin/packages/rayleigh/package.py Show resolved Hide resolved
var/spack/repos/builtin/packages/rayleigh/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/rayleigh/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/rayleigh/package.py Outdated Show resolved Hide resolved
@wdconinc wdconinc self-assigned this May 18, 2024
wdconinc
wdconinc previously approved these changes May 20, 2024
View reviewed changes
@wdconinc wdconinc enabled auto-merge (squash) May 20, 2024 23:13
@wdconinc wdconinc merged commit 2113994 into spack:develop May 21, 2024
14 checks passed
@tukss tukss deleted the rayleigh branch May 21, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wdconinc wdconinc wdconinc approved these changes

Assignees

@wdconinc wdconinc

Labels
dependencies maintainers new-package new-version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tukss @wdconinc