-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update QGIS source code url #40538
Update QGIS source code url #40538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't actually matter (Spack knows how to infer the correct URL) but I don't mind +1 contributors.
@agiudiceandrea you could help by adding adding version 3.32.3 to the package file. We can confirm if it builds or not later. We would still keep 3.28.11 as preferred version. |
@agiudiceandrea Did you want to add the more recent version per #40538 (comment)? If not, we can just go ahead and merge this. I rebased to get past the failing gitlab check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this PR motivated by an issue you encountered, or a misunderstanding on how Spack parses URLs? If you run spack info qgis
, you'll see that Spack knows how to detect and replace the version in the URL without needing to update or change it.
@@ -13,7 +13,7 @@ class Qgis(CMakePackage): | |||
""" | |||
|
|||
homepage = "https://qgis.org" | |||
url = "https://qgis.org/downloads/qgis-3.8.1.tar.bz2" | |||
url = "https://qgis.org/downloads/qgis-latest.tar.bz2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change will break Spack's version detection:
> spack url parse https://qgis.org/downloads/qgis-latest.tar.bz2
==> Parsing URL: https://qgis.org/downloads/qgis-latest.tar.bz2
==> Error: Couldn't detect version in: https://qgis.org/downloads/qgis-latest.tar.bz2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it is useless to merge this PR. Thank you anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the way to add new versions is to add the version
directives with the sha256
checksums. The URL is deduced automatically. This can be done easily with spack checksum qgis
.
How about we close this PR and open a new PR for added versions (and their changed dependencies)? |
It would be nice to have latest LTR version, 3.34.6 added after checking that it builds just fine. |
No description provided.