Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QGIS source code url #40538

Closed
wants to merge 2 commits into from
Closed

Conversation

agiudiceandrea
Copy link

No description provided.

adamjstewart
adamjstewart previously approved these changes Oct 15, 2023
Copy link
Member

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't actually matter (Spack knows how to infer the correct URL) but I don't mind +1 contributors.

@Sinan81
Copy link
Contributor

Sinan81 commented Oct 16, 2023

@agiudiceandrea you could help by adding adding version 3.32.3 to the package file. We can confirm if it builds or not later. We would still keep 3.28.11 as preferred version.

@wdconinc
Copy link
Contributor

@agiudiceandrea Did you want to add the more recent version per #40538 (comment)? If not, we can just go ahead and merge this. I rebased to get past the failing gitlab check.

@wdconinc wdconinc self-assigned this May 19, 2024
Copy link
Member

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR motivated by an issue you encountered, or a misunderstanding on how Spack parses URLs? If you run spack info qgis, you'll see that Spack knows how to detect and replace the version in the URL without needing to update or change it.

@@ -13,7 +13,7 @@ class Qgis(CMakePackage):
"""

homepage = "https://qgis.org"
url = "https://qgis.org/downloads/qgis-3.8.1.tar.bz2"
url = "https://qgis.org/downloads/qgis-latest.tar.bz2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will break Spack's version detection:

> spack url parse https://qgis.org/downloads/qgis-latest.tar.bz2
==> Parsing URL: https://qgis.org/downloads/qgis-latest.tar.bz2

==> Error: Couldn't detect version in: https://qgis.org/downloads/qgis-latest.tar.bz2

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it is useless to merge this PR. Thank you anyway.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the way to add new versions is to add the version directives with the sha256 checksums. The URL is deduced automatically. This can be done easily with spack checksum qgis.

@wdconinc
Copy link
Contributor

How about we close this PR and open a new PR for added versions (and their changed dependencies)?

@Sinan81
Copy link
Contributor

Sinan81 commented May 19, 2024

It would be nice to have latest LTR version, 3.34.6 added after checking that it builds just fine.
One could also deprecate all in-between older versions that are not 3.xx.15 or 3.xx16.
last time I checked version 3.36 wasn't building. It would be great to fix that but it might be considerably more work than the items listed above.

@agiudiceandrea agiudiceandrea deleted the patch-1 branch May 19, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants