-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump-up rocm-opencl with 6.1.0 & 6.1.1 and adding hsa library path in LD_LIBRARY_PATH #44171
Merged
tldahlgren
merged 3 commits into
spack:develop
from
renjithravindrankannath:hsa-rocr-dev-dependency
May 31, 2024
Merged
Bump-up rocm-opencl with 6.1.0 & 6.1.1 and adding hsa library path in LD_LIBRARY_PATH #44171
tldahlgren
merged 3 commits into
spack:develop
from
renjithravindrankannath:hsa-rocr-dev-dependency
May 31, 2024
+22
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@spackbot rerun pipeline |
I've started that pipeline for you! |
@spackbot rerun pipeline |
I've started that pipeline for you! |
@spackbot rerun pipeline |
I've started that pipeline for you! |
LGTM. |
srekolam
approved these changes
May 30, 2024
Hi @tldahlgren , Can you please review and approve. |
srekolam
approved these changes
May 31, 2024
renjithravindrankannath
changed the title
Adding hsa library path in LD_LIBRARY_PATH
Adding rocm-opencl 6.1.0 & 6.1.1 updates and adding hsa library path in LD_LIBRARY_PATH
May 31, 2024
renjithravindrankannath
changed the title
Adding rocm-opencl 6.1.0 & 6.1.1 updates and adding hsa library path in LD_LIBRARY_PATH
Bump-up rocm-opencl with 6.1.0 & 6.1.1 and adding hsa library path in LD_LIBRARY_PATH
May 31, 2024
tldahlgren
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed the sha256s, rest LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding hsa library path in LD_LIBRARY_PATH as amdgpu-arch required libamdhip64.so and libhsa-runtime64.so.
https://github.com/ROCm/llvm-project/blob/rocm-6.1.x/clang/tools/amdgpu-arch/AMDGPUArchByHIP.cpp#L45
https://github.com/ROCm/clr/blob/rocm-6.1.0/hipamd/hip-config-amd.cmake#L77