-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flux-sched: add v0.34.0 #44205
base: develop
Are you sure you want to change the base?
flux-sched: add v0.34.0 #44205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are failures in CI:
It seems some part of the latest release requires C++ 20, and in CI we are compiling with GCC 7.3.1
We might need some minimum version for the compiler, for the time being. This will change soon, since we'd like to allow declarations like:
depends_on("cxx std=20")
and have Spack figure out automatically if a compiler fits.
Currently we test most heavily with gcc12+ and clang15+. In principle gcc10 and 11 might also work, but I haven't done much work on ensuring that. I have another fix that needs to go into this package later as it happens, as soon as this one goes in I'll post that up (it has to do with the version override code added recently). |
I missed that this hasn't been done. We currently test in CI with gcc 9.4+ and clang15+, so those are safe to pin to. We may have to raise the gcc at some point because of library usage, but it's good for now. |
@trws so are you no longer working on an update for this and handing back to me to make those pins? I can update the PR to do exactly that. |
Ah, I must have miscommunicated, sorry about that. I was hoping you would do that here yes. |
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Tested locally with the gcc pin - let's see if that changes clang too. If not, I need some guidance on what to set for that. |
@alalazo looks like we have the same issue - let me know what you'd like to do. |
You probably want |
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
No description provided.