Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flux-sched: add v0.34.0 #44205

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

vsoch
Copy link
Member

@vsoch vsoch commented May 15, 2024

No description provided.

Copy link
Member

@alalazo alalazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are failures in CI:

It seems some part of the latest release requires C++ 20, and in CI we are compiling with GCC 7.3.1

We might need some minimum version for the compiler, for the time being. This will change soon, since we'd like to allow declarations like:

depends_on("cxx std=20")

and have Spack figure out automatically if a compiler fits.

@alalazo alalazo self-assigned this May 17, 2024
@vsoch
Copy link
Member Author

vsoch commented May 17, 2024

Ping @trws and @grondo - what do you think about pinning a gcc version (I think that's what is being asked above) to determine the latter?

@trws
Copy link
Contributor

trws commented May 17, 2024

Currently we test most heavily with gcc12+ and clang15+. In principle gcc10 and 11 might also work, but I haven't done much work on ensuring that. I have another fix that needs to go into this package later as it happens, as soon as this one goes in I'll post that up (it has to do with the version override code added recently).

@alecbcs alecbcs changed the title flux-sched: add 0.34.0 flux-sched: add v0.34.0 May 17, 2024
@trws
Copy link
Contributor

trws commented May 24, 2024

I missed that this hasn't been done. We currently test in CI with gcc 9.4+ and clang15+, so those are safe to pin to. We may have to raise the gcc at some point because of library usage, but it's good for now.

@vsoch
Copy link
Member Author

vsoch commented May 24, 2024

@trws so are you no longer working on an update for this and handing back to me to make those pins? I can update the PR to do exactly that.

@trws
Copy link
Contributor

trws commented May 24, 2024

Ah, I must have miscommunicated, sorry about that. I was hoping you would do that here yes.

@vsoch
Copy link
Member Author

vsoch commented May 25, 2024

No worries @trws I'm glad you checked in again!

@alalazo how do I specify the clang pin? For gcc I'm adding:

depends_on("gcc@9.4:")

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
@vsoch
Copy link
Member Author

vsoch commented May 25, 2024

Tested locally with the gcc pin - let's see if that changes clang too. If not, I need some guidance on what to set for that.

@vsoch
Copy link
Member Author

vsoch commented May 25, 2024

@alalazo looks like we have the same issue - let me know what you'd like to do.

@trws
Copy link
Contributor

trws commented May 28, 2024

You probably want requires("%gcc@9.4:") or conflicts("%gcc@:9.3") rather than depends, since it isn't a build dependency as such yet.

vsoch added 4 commits May 28, 2024 12:38
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
@vsoch
Copy link
Member Author

vsoch commented May 28, 2024

@trws @alalazo neither of those worked so I will need to ask for you help again - what should we try next?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants