Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libxc: Fix compilation after distribution changes #44206

Merged
merged 1 commit into from
May 17, 2024

Conversation

RemiLacroix-IDRIS
Copy link
Contributor

Probably a side effect of a change on Gitlab side.

Copy link

spackbot-app bot commented May 15, 2024

Hi @RemiLacroix-IDRIS! I noticed that the following package(s) don't yet have maintainers:

  • libxc

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("RemiLacroix-IDRIS")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame libxc

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@RemiLacroix-IDRIS RemiLacroix-IDRIS marked this pull request as draft May 15, 2024 15:48
@RemiLacroix-IDRIS
Copy link
Contributor Author

I have changed this PR to a draft as it seems that the problem is more complex than I initially realized.

The release tarballs are not available anymore which means autoconf, automake and libtool are always needed.

The NVHPC specific patches don't make sense anymore being that the patched files are not distributed in the new tar files.
@RemiLacroix-IDRIS RemiLacroix-IDRIS changed the title libxc: Update the checksum for all versions libxc: Fix compilation after distribution changes May 16, 2024
@RemiLacroix-IDRIS RemiLacroix-IDRIS marked this pull request as ready for review May 16, 2024 15:35
@RemiLacroix-IDRIS
Copy link
Contributor Author

Removed the WIP tag, I have pushed a new commit which fixes all the issues.

@alalazo alalazo self-assigned this May 17, 2024
@RemiLacroix-IDRIS
Copy link
Contributor Author

@alalazo: I should have updated the description of this PR with the content of my new commit message:

libxc: Fix compilation after distribution changes.

The release tarballs are not available anymore which means autoconf, automake and libtool are always needed.

The NVHPC specific patches don't make sense anymore being that the patched files are not distributed in the new tar files.

@alalazo alalazo merged commit 453900c into spack:develop May 17, 2024
14 checks passed
@RemiLacroix-IDRIS RemiLacroix-IDRIS deleted the patch-3 branch May 17, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants