Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch Node.traverse() to findall() to avoid deprecation warnings #758

Merged
merged 3 commits into from May 5, 2024

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented Aug 25, 2023

This should be OK to switch straight to .findall() with no need to try/except and fall back to .traverse() since sphinx requires docutils >= 0.18.1

@mgeier
Copy link
Member

mgeier commented Apr 6, 2024

Thanks for this PR, and sorry for my very late response!

Before merging this, I would like to check which versions I want to support and re-activate the tests, see #495.

For now, I have silenced the warning (a1a56f5), which can be reverted once this is merged.

@mgeier
Copy link
Member

mgeier commented May 4, 2024

I have finally checked which versions I want to support and I have re-activated the tests in #792.

Can you please re-base your PR and add a lower bound to our docutils dependency?

'docutils',

@wpbonelli
Copy link
Contributor Author

@mgeier sure! done.

@mgeier mgeier merged commit d30467f into spatialaudio:master May 5, 2024
12 checks passed
@mgeier
Copy link
Member

mgeier commented May 5, 2024

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants