Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Carbon 3 rawAddUnit type #131

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Fix Carbon 3 rawAddUnit type #131

merged 1 commit into from
Apr 15, 2024

Conversation

clementmas
Copy link
Contributor

This PR fixes Carbon 3 support for declaring:

HONEYPOT_SECONDS=1

Which will return a string instead of int and throw this error:

Carbon\Carbon::rawAddUnit(): Argument #3 ($value) must be of type int|float, string given, called in vendor\nesbot\carbon\src\Carbon\Traits\Units.php on line 356

@freekmurze freekmurze merged commit 83036d9 into spatie:main Apr 15, 2024
18 checks passed
@freekmurze
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants