Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent behaviour between LicenseCompareHelper methods when called with official MIT license text #234

Open
pmonks opened this issue Apr 12, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@pmonks
Copy link
Collaborator

pmonks commented Apr 12, 2024

When the various org.spdx.utility.compare.LicenseCompareHelper methods are called with the official MIT license text, the library gives inconsistent results (emoji represent whether each one is an expected result or not):

  • .isTextStandardLicense("MIT", <text>).isDifferenceFound() returns false
  • .isStandardLicenseWithinText(<text>, "MIT") returns false
  • .matchingStandardLicenseIds(<text>) returns an empty array ❌
  • .matchingStandardLicenseIdsWithinText(<text>) returns an empty array ❌

Tested with Spdx-Java-Library v.1.11 and SPDX license list 3.23.

@pmonks pmonks added the bug Something isn't working label Apr 12, 2024
@pmonks
Copy link
Collaborator Author

pmonks commented Apr 19, 2024

FYI this seems to be a regression of issue #182, as I'm seeing it with some BSD texts too.

pmonks added a commit to pmonks/Spdx-Java-Library that referenced this issue Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant