Add unit tests that exercise issue #234 #236
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @pmonks - creating unit tests will help in diagnosing/fixing the issues. It may be a while before I can look at these issues - I'm prioritizing getting the SPDX 3.0 supported. |
|
@goneall yep absolutely no problem - I know just how busy you've been with the 3.0 release and updating the library to match! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests that exercise issue #234. They're (deliberately) minimal, since license comparison is expensive and already a sizable portion of the runtime of the unit tests, but they at least show what's going on with that issue as of v1.11 of the library.
Note: the tests are failing because this PR only adds (previously missing) unit tests to demonstrate issue #234, but not logic to fix it.