Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cross-ref for ISC-Veillard variant #2455

Merged
merged 2 commits into from May 15, 2024

Conversation

nwellnhof
Copy link
Contributor

This license originates from the Trio printf library.

This license originates from the Trio printf library.
@xsuchy
Copy link
Collaborator

xsuchy commented Apr 21, 2024

+1 to adding crossref, but not sure about the note.

@jlovejoy jlovejoy added the minor updates to file URL update, notes update, etc. label May 2, 2024
@jlovejoy jlovejoy added this to the 3.24 milestone May 2, 2024
@jlovejoy
Copy link
Member

jlovejoy commented May 2, 2024

@nwellnhof - thanks for the URL addition. We use the Notes for pretty limited scope of information, see https://github.com/spdx/license-list-XML/blob/main/DOCS/license-fields.md#d-notes
Did you have a particular thought behind adding it?

@nwellnhof
Copy link
Contributor Author

Did you have a particular thought behind adding it?

Well, the name ISC-Veillard is a bit misleading. It is used in libxml2, originally authored by Daniel Veillard, but this license was copied from the Trio library which I think is the original source.

@swinslow
Copy link
Member

swinslow commented May 9, 2024

Discussed on 2024-05-09 legal team call. We're good to include the note, but we'd lean towards saying "It appears to originate from Trio" rather than "It originates from Trio" since we usually don't opine definitively on license history.

I'll make this change and then merge. Thank you all!

Signed-off-by: Steve Winslow <steve@swinslow.net>
@swinslow swinslow merged commit ea01635 into spdx:main May 15, 2024
2 checks passed
@nwellnhof nwellnhof deleted the amend-isc-veillard branch May 15, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor updates to file URL update, notes update, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants