Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix all jsonld examples #762

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

maxhbr
Copy link
Member

@maxhbr maxhbr commented May 3, 2024

The current examples in serializaiton/json_ld/examples are all except one invalid.

Signed-off-by: Maximilian Huber <maximilian.huber@tngtech.com>
"element": [
"https://some.namespace#SPDXRef-Package",
"https://some.namespace#File1",
"https://some.namespace#file1",
"https://some.namespace#file2",
"https://spdx.dev/elements/3F26391C#spdx-spec-v2.3",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the creator "https://spdx.dev/elements/3F26391C#spdx-spec-v2.3", is listed in "element" of the SpdxDocument but is not contained in the file

@maxhbr
Copy link
Member Author

maxhbr commented May 3, 2024

the "profileConformance" value "licensing" causes the parser to fail -> got dropped.

@maxhbr maxhbr marked this pull request as draft May 3, 2024 14:04
@maxhbr
Copy link
Member Author

maxhbr commented May 3, 2024

The SoftwareDependencyRelationship used in contverted_from_spdx_2.json seems to have vanished without replacement. How would one express dynamic linking?

Signed-off-by: Maximilian Huber <maximilian.huber@tngtech.com>
@maxhbr
Copy link
Member Author

maxhbr commented May 3, 2024

There are now no examples demonstrating contentIdentifier, this should be added

Signed-off-by: Maximilian Huber <maximilian.huber@tngtech.com>
@maxhbr
Copy link
Member Author

maxhbr commented May 3, 2024

Generated with https://github.com/maxhbr/spdx3ToGraph:

two_sboms json
tool1 json
spdx_document4 json
spdx_document3 json
spdx_document2 json
spdx_document1 json
sbom1 json
relationship1 json
person3 json
person2 json
person1 json
package1 json
org1 json
file1 json
converted_from_spdx_2 json
annotation1 json
agent1 json

@maxhbr maxhbr marked this pull request as ready for review May 3, 2024 15:06
Signed-off-by: Maximilian Huber <maximilian.huber@tngtech.com>
@maxhbr maxhbr changed the title start fixing examples fix all jsonld examples May 3, 2024
@kestewart kestewart requested review from rnjudge, zvr and puerco May 7, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants