#200 - Fixing test_archive_license_requests_feature and test_unarchive_license_requests_feature #457

BanulaKumarage · 2023-04-01T08:44:13Z

Logged in with the user setup in secrets.py
Add client sessionid to selenium driver
Mocked the app.utils.checkPermission to return true

When the app.utils.checkPermission returns true, context_dict['authorized'] becomes true and that cause archive/ unarchive buttons visible in the UI.

…chive_license_requests_feature Mocked utils.checkPermissionto retrurn true

rtgdk

Overall LGTM, left 1 comment to address

rtgdk · 2023-04-16T03:37:10Z

src/app/tests.py

+        self.user = authenticate(username=TEST_LOGIN_INFO["login"],
+                                 password=TEST_LOGIN_INFO["password"])
+        login = self.client.login(username=TEST_LOGIN_INFO["login"],
+                                  password=TEST_LOGIN_INFO["password"])


Let's create a TestUtil for common code to setup github login.

A separate class or a function inside the ArchiveLicenseRequestsViewsTestCase?

@rtgdk Should I include this in utils.py or a separate file named testUtils.py

Let's have test_utils.py or keep the util inside tests.py itself.

@rtgdk done

sonatype-lift · 2023-04-16T05:14:37Z

src/app/tests.py

@@ -21,6 +22,7 @@

 from app.models import UserID
 from app.models import LicenseRequest, LicenseNamespace
+import app.utils


F401: 'app.utils' imported but unused

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-04-16T05:14:39Z

src/app/tests.py

@@ -31,6 +33,32 @@
 def getExamplePath(filename):
    return os.path.join(settings.EXAMPLES_DIR, filename)

+class TestUtil(TestCase):


E302: expected 2 blank lines, found 1

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-04-16T05:14:41Z

src/app/tests.py

+        login = self.client.login(username=TEST_LOGIN_INFO["login"],
+                                  password=TEST_LOGIN_INFO["password"])
+        return login
+


W293: blank line contains whitespace

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-04-16T05:14:43Z

src/app/tests.py

+        with patch('app.utils.checkPermission') as mock_checkPermission:
+            mock_checkPermission.return_value = True
+            driver.get(self.live_server_url+'/app/license_requests/')
+            driver.add_cookie({'name': 'sessionid', 'value': cookie.value, 'secure': False, 'path': '/'})


E501: line too long (105 > 79 characters)

❗❗ 11 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

src/app/tests.py 1147

src/app/tests.py 1151

src/app/tests.py 1152

src/app/tests.py 1153

src/app/tests.py 1155

src/app/tests.py 1169

src/app/tests.py 1172

src/app/tests.py 1176

src/app/tests.py 1177

src/app/tests.py 1178

Showing 10 of 11 findings. Visit the Lift Web Console to see all.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@sonatype-lift ignoreall

The ignoreall command is active on this PR, all the existing Lift issues are ignored.

BanulaKumarage added 2 commits April 1, 2023 14:06

spdx#200 - Fixing test_archive_license_requests_feature and test_unar…

3ae1f89

…chive_license_requests_feature Mocked utils.checkPermissionto retrurn true

Update tests.py

a52e66d

BanulaKumarage mentioned this pull request Apr 1, 2023

#200 Fixing Unit test failure - test_archive_license_requests_feature #445

Closed

rtgdk reviewed Apr 16, 2023

View reviewed changes

Adding github Login to TestUtil

776e3bd

BanulaKumarage requested a review from rtgdk April 16, 2023 05:09

sonatype-lift bot reviewed Apr 16, 2023

View reviewed changes

Formatting

44329b4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#200 - Fixing test_archive_license_requests_feature and test_unarchive_license_requests_feature #457

#200 - Fixing test_archive_license_requests_feature and test_unarchive_license_requests_feature #457

BanulaKumarage commented Apr 1, 2023 •

edited

rtgdk left a comment

rtgdk Apr 16, 2023

BanulaKumarage Apr 16, 2023

BanulaKumarage Apr 16, 2023

rtgdk Apr 16, 2023 •

edited

BanulaKumarage Apr 16, 2023

sonatype-lift bot Apr 16, 2023

sonatype-lift bot Apr 16, 2023

sonatype-lift bot Apr 16, 2023

sonatype-lift bot Apr 16, 2023

BanulaKumarage Apr 16, 2023

sonatype-lift bot Apr 16, 2023

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

File Path	Line Number
src/app/tests.py	1147
src/app/tests.py	1151
src/app/tests.py	1152
src/app/tests.py	1153
src/app/tests.py	1155
src/app/tests.py	1169
src/app/tests.py	1172
src/app/tests.py	1176
src/app/tests.py	1177
src/app/tests.py	1178

#200 - Fixing test_archive_license_requests_feature and test_unarchive_license_requests_feature #457

Are you sure you want to change the base?

#200 - Fixing test_archive_license_requests_feature and test_unarchive_license_requests_feature #457

Conversation

BanulaKumarage commented Apr 1, 2023 • edited

rtgdk left a comment

Choose a reason for hiding this comment

rtgdk Apr 16, 2023

Choose a reason for hiding this comment

BanulaKumarage Apr 16, 2023

Choose a reason for hiding this comment

BanulaKumarage Apr 16, 2023

Choose a reason for hiding this comment

rtgdk Apr 16, 2023 • edited

Choose a reason for hiding this comment

BanulaKumarage Apr 16, 2023

Choose a reason for hiding this comment

sonatype-lift bot Apr 16, 2023

Choose a reason for hiding this comment

sonatype-lift bot Apr 16, 2023

Choose a reason for hiding this comment

sonatype-lift bot Apr 16, 2023

Choose a reason for hiding this comment

sonatype-lift bot Apr 16, 2023

Choose a reason for hiding this comment

BanulaKumarage Apr 16, 2023

Choose a reason for hiding this comment

sonatype-lift bot Apr 16, 2023

Choose a reason for hiding this comment

BanulaKumarage commented Apr 1, 2023 •

edited

rtgdk Apr 16, 2023 •

edited