address pr comments

Signed-off-by: Brandon Lum <lumjjb@gmail.com>
spdx · May 26, 2023 · fb0f8d8 · fb0f8d8
1 parent 6b2ab7a
commit fb0f8d8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/spdx/v2/v2_2/json/json_test.go b/spdx/v2/v2_2/json/json_test.go
@@ -175,7 +175,7 @@ func Test_ShorthandFields(t *testing.T) {
 	}
 
 	if diff := cmp.Diff(want, doc, cmpopts.IgnoreUnexported(spdx.Package{}), cmpopts.SortSlices(relationshipLess)); len(diff) > 0 {
-		t.Errorf("got incorrect struct after parsing JSON example: %s", cmp.Diff(want, doc, cmpopts.IgnoreUnexported(spdx.Package{})))
+		t.Errorf("got incorrect struct after parsing JSON example: %s", diff)
 		return
 	}
 

diff --git a/spdx/v2/v2_3/json/json_test.go b/spdx/v2/v2_3/json/json_test.go
@@ -194,7 +194,7 @@ func Test_ShorthandFields(t *testing.T) {
 	}
 
 	if diff := cmp.Diff(want, doc, cmpopts.IgnoreUnexported(spdx.Package{}), cmpopts.SortSlices(relationshipLess)); len(diff) > 0 {
-		t.Errorf("got incorrect struct after parsing JSON example: %s", cmp.Diff(want, doc, cmpopts.IgnoreUnexported(spdx.Package{})))
+		t.Errorf("got incorrect struct after parsing JSON example: %s", diff)
 		return
 	}
 }